Debian bug report logs - #963
INN breaks on overly-long Message-ID's

Message received at debian-bugs:

From cus.cam.ac.uk!iwj10 Wed Jun 21 09:14:50 1995
Return-Path: <iwj10@cus.cam.ac.uk>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0sOSQU-0006c3C; Wed, 21 Jun 95 09:14 PDT
Received: from bootes.cus.cam.ac.uk by pixar.com with SMTP id AA13317
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Wed, 21 Jun 1995 09:13:19 -0700
Received: by bootes.cus.cam.ac.uk 
	(Smail-3.1.29.0 #36) id m0sOSMN-000C0CC; Wed, 21 Jun 95 17:10 BST
Received: by chiark
	id <m0sODkd-0000XMZ@chiark.al.cl.cam.ac.uk>
	(Debian /\oo/\ Smail3.1.29.1 #29.32); Wed, 21 Jun 95 01:34 BST
Message-Id: <m0sODkd-0000XMZ@chiark.al.cl.cam.ac.uk>
Date: Wed, 21 Jun 95 01:34 BST
From: iwj10@cus.cam.ac.uk (Ian Jackson)
To: Stephen Darragh <stephen@belgarath.it.com.au>,
        Debian bugs submission address <debian-bugs@pixar.com>
X-Debian-Pr: quiet
Subject: Bug#963: Re: INN breaks on overly-long Message-ID's
In-Reply-To: <8124441@toto.iv>

I wrote:
> I saw the attached message as part of a thread in news.software.nntp.
> It looks like we should apply a patch somewhat like this in Debian.

Here's a followup that is probably important.

I'm filing this message with the original report, again with
`X-Debian-PR: quiet' to stop my message being reflected on
debian-devel.

Ian.

Newsgroups: news.software.nntp
Message-ID: <3r49tl$16ft@bcx01.boco.co.gov>
References: <3qitge$dv8@ns1.win.net> <3qkil1$8f1@europa.chnt.gtegsc.com>
From: swcxt@boco.co.gov (Shane Castle)
Subject: Re: Bad message IDs hosing INN1.4
Date: 7 Jun 1995 07:34:45 -0600

The patch that was posted here won't apply using Larry Wall's
patch-2.1; apparently the poster forgot to turn off autoindent when he
copied in his patch.  Here is the corrected version, removing the
profanity as well.

--- art.c.orig	Thu Jan  5 07:24:56 1995
+++ art.c	Wed Jun  7 07:29:51 1995
@@ -1713,6 +1713,11 @@
     Data.FeedsiteLength = strlen(Data.Feedsite);
     (void)sprintf(Data.TimeReceived, "%lu", Now.time);
     Data.TimeReceivedLength = strlen(Data.TimeReceived);
+    Data.MessageIDLength = strlen(Data.MessageID);
+ 
+    /* if ID is too long */
+    if (Data.MessageIDLength > (DBZMAXKEY/2))
+        error = "Message ID is too long";
 
     /* A duplicate? */
     if (error == NULL && HIShavearticle(Data.MessageID))

--
Shane Castle             | "Perfection, then, is finally achieved, not
Boulder County Info Svcs | when there is nothing left to add, but when
Boulder CO USA           | there is nothing left to take away."
                         |                - Antoine de Saint-Exupiry

Message received at debian-bugs:

From cus.cam.ac.uk!iwj10 Thu Jun  8 05:15:37 1995
Return-Path: <iwj10@cus.cam.ac.uk>
Received: from pixar.com by mongo.pixar.com with smtp
	(Smail3.1.28.1 #15) id m0sJgUr-0005ObC; Thu, 8 Jun 95 05:15 PDT
Received: from bootes.cus.cam.ac.uk by pixar.com with SMTP id AA19194
  (5.67b/IDA-1.5 for debian-bugs-pipe@mongo.pixar.com); Thu, 8 Jun 1995 05:14:08 -0700
Received: by bootes.cus.cam.ac.uk 
	(Smail-3.1.29.0 #36) id m0sJgTg-000BzxC; Thu, 8 Jun 95 13:14 BST
Received: by chiark
	id <m0sJU6A-0000YKZ@chiark.al.cl.cam.ac.uk>
	(Debian /\oo/\ Smail3.1.29.1 #29.31); Thu, 8 Jun 95 00:01 BST
Message-Id: <m0sJU6A-0000YKZ@chiark.al.cl.cam.ac.uk>
Date: Thu, 8 Jun 95 00:01 BST
From: iwj10@cus.cam.ac.uk (Ian Jackson)
To: Stephen Darragh <stephen@belgarath.it.com.au>,
        Debian bugs submission address <debian-bugs@pixar.com>
Subject: INN breaks on overly-long Message-ID's
X-Debian-Pr: quiet

Package: inn
Version: 1.4sec-7

I saw the attached message as part of a thread in news.software.nntp.
It looks like we should apply a patch somewhat like this in Debian.

I'm filing this as a bug report, with `X-Debian-PR: quiet' to stop my
message being reflected on debian-devel.

Ian.

------- start of forwarded message (RFC 934 encapsulation) -------
Article: 693 of news.software.nntp
Path: chiark.culture.org!lyra.csx.cam.ac.uk!sunsite.doc.ic.ac.uk!uknet!demon!news.sprintlink.net!europa.chnt.gtegsc.com!usenet
Newsgroups: news.software.nntp
Organization: GTE Informations Systems Division
Lines: 31
Distribution: inet
Message-ID: <3qkil1$8f1@europa.chnt.gtegsc.com>
References: <3qitge$dv8@ns1.win.net>
Reply-To: castro@eng.gtefsd.com
NNTP-Posting-Host: vette.eng.gtefsd.com
From: castro@eng.gtefsd.com (J. Carlos Castro)
Subject: Re: Bad message IDs hosing INN1.4
Date: 1 Jun 1995 14:25:37 GMT

I believe this patch will keep us from accepting articles with message IDs
over 127 characters log.

I hope this helps.... my news machine has not barfed with this yet :)


*** art.orig.c  Wed May 31 18:25:39 1995
- --- art.c       Wed May 31 18:36:20 1995
***************
*** 1713,1718 ****
- --- 1713,1723 ----
      Data.FeedsiteLength = strlen(Data.Feedsite);
	    (void)sprintf(Data.TimeReceived, "%lu", Now.time);
		  Data.TimeReceivedLength = strlen(Data.TimeReceived);
		  +     Data.MessageIDLength = strlen(Data.MessageID);
		  + 
		  +     /* if ID is too long */
		  +     if (Data.MessageIDLength > (DBZMAXKEY/2))
		  +       error = "Damn ID is too long";
		    
			  /* A duplicate? */
				if (error == NULL && HIShavearticle(Data.MessageID))


- -- 
- ----------------------| Systems Administrator 
J. Carlos Castro      | Software Engineering Environment
http://www.gtefsd.com/| 15000 Conference Center Drive
castro@eng.gtefsd.com | GTE Federal Systems Chantilly, Virginia 



------- end -------